Skip to content

[v22.x backport] tools: extract target abseil to abseil.gyp #57982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

[v22.x backport] tools: extract target abseil to abseil.gyp #57982

merged 2 commits into from
May 18, 2025
+337 −316

Conversation

legendecas
Copy link
Member

Both V8 and perfetto depends on abseil. When perfetto support is enabled, V8 also depends on perfetto.

In order to share abseil between perfetto and V8 targets, and avoid cycle dependencies between v8.gyp and perfetto.gyp, this extracts target abseil from v8.gyp to an independent file abseil.gyp.

PR-URL: #57289
Refs: nodejs/diagnostics#654
Reviewed-By: Richard Lau [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Michaël Zasso [email protected]

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@legendecas legendecas changed the title tools: extract target abseil to abseil.gyp [v22.x] tools: extract target abseil to abseil.gyp Apr 22, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Apr 22, 2025
@aduh95 aduh95 changed the title [v22.x] tools: extract target abseil to abseil.gyp [v22.x backport] tools: extract target abseil to abseil.gyp May 6, 2025
@aduh95 aduh95 mentioned this pull request May 6, 2025
Merged
@aduh95
Copy link
Contributor

aduh95 commented May 6, 2025

Can you add #57582 and #57870 to this PR please?

@legendecas legendecas force-pushed the backport-57289-to-22 branch from b6af552 to ee5f46a Compare May 12, 2025 12:56
@legendecas
Copy link
Member Author

Added #57582 to this backport.

#57870 should not be backported though. Removed backport label on it.

@RafaelGSS RafaelGSS requested a review from a team as a code owner May 14, 2025 20:50
@aduh95 aduh95 force-pushed the backport-57289-to-22 branch from ee5f46a to c8e3383 Compare May 17, 2025 12:36
aduh95 pushed a commit to legendecas/node that referenced this pull request May 17, 2025
@legendecas @aduh95
tools: extract target abseil to abseil.gyp
f15ebbd 
Both V8 and perfetto depends on abseil. When perfetto support is
enabled, V8 also depends on perfetto.

In order to share abseil between perfetto and V8 targets, and avoid
cycle dependencies between `v8.gyp` and `perfetto.gyp`, this extracts
target `abseil` from `v8.gyp` to an independent file `abseil.gyp`.

PR-URL: nodejs#57289
Backport-PR-URL: nodejs#57982
Refs: nodejs/diagnostics#654
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
aduh95 pushed a commit to legendecas/node that referenced this pull request May 17, 2025
@legendecas @aduh95
src: disable abseil deadlock detection
c8e3383 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: nodejs#57582
Backport-PR-URL: nodejs#57982
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66860/

@aduh95 aduh95 force-pushed the v22.x-staging branch 3 times, most recently from e0a025a to d03f13a Compare May 17, 2025 13:54
@aduh95 aduh95 force-pushed the backport-57289-to-22 branch from c8e3383 to 3149aaf Compare May 17, 2025 13:55
aduh95 pushed a commit to legendecas/node that referenced this pull request May 17, 2025
@legendecas @aduh95
tools: extract target abseil to abseil.gyp
e864f0f 
Both V8 and perfetto depends on abseil. When perfetto support is
enabled, V8 also depends on perfetto.

In order to share abseil between perfetto and V8 targets, and avoid
cycle dependencies between `v8.gyp` and `perfetto.gyp`, this extracts
target `abseil` from `v8.gyp` to an independent file `abseil.gyp`.

PR-URL: nodejs#57289
Backport-PR-URL: nodejs#57982
Refs: nodejs/diagnostics#654
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
aduh95 pushed a commit to legendecas/node that referenced this pull request May 17, 2025
@legendecas @aduh95
src: disable abseil deadlock detection
3149aaf 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: nodejs#57582
Backport-PR-URL: nodejs#57982
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66862/

@aduh95 aduh95 force-pushed the backport-57289-to-22 branch from 3149aaf to bd43b7b Compare May 17, 2025 15:24
aduh95 pushed a commit to legendecas/node that referenced this pull request May 17, 2025
@legendecas @aduh95
tools: extract target abseil to abseil.gyp
95c9c4f 
Both V8 and perfetto depends on abseil. When perfetto support is
enabled, V8 also depends on perfetto.

In order to share abseil between perfetto and V8 targets, and avoid
cycle dependencies between `v8.gyp` and `perfetto.gyp`, this extracts
target `abseil` from `v8.gyp` to an independent file `abseil.gyp`.

PR-URL: nodejs#57289
Backport-PR-URL: nodejs#57982
Refs: nodejs/diagnostics#654
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
aduh95 pushed a commit to legendecas/node that referenced this pull request May 17, 2025
@legendecas @aduh95
src: disable abseil deadlock detection
bd43b7b 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: nodejs#57582
Backport-PR-URL: nodejs#57982
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66869/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66871/

legendecas added 2 commits May 18, 2025 22:34
@legendecas @aduh95
tools: extract target abseil to abseil.gyp
a23f57f 
Both V8 and perfetto depends on abseil. When perfetto support is
enabled, V8 also depends on perfetto.

In order to share abseil between perfetto and V8 targets, and avoid
cycle dependencies between `v8.gyp` and `perfetto.gyp`, this extracts
target `abseil` from `v8.gyp` to an independent file `abseil.gyp`.

PR-URL: nodejs#57289
Backport-PR-URL: nodejs#57982
Refs: nodejs/diagnostics#654
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@legendecas @aduh95
src: disable abseil deadlock detection
6ea250e 
Abseil deadlock detection is reporting false positives in tests.
Disable it for now.

PR-URL: nodejs#57582
Backport-PR-URL: nodejs#57982
Refs: nodejs/node-v8#301
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@aduh95 aduh95 force-pushed the backport-57289-to-22 branch from bd43b7b to 6ea250e Compare May 18, 2025 20:35
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66907/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66912/

@aduh95 aduh95 merged commit 6ea250e into nodejs:v22.x-staging May 18, 2025
50 of 53 checks passed
@aduh95
Copy link
Contributor

aduh95 commented May 18, 2025

Landed in cd4e09d...6ea250e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legendecas @nodejs-github-bot @aduh95 @RafaelGSS